plusplusjiajia commented on code in PR #898:
URL: https://github.com/apache/iceberg-cpp/pull/898#discussion_r4110394586
##########
src/iceberg/arrow/s3/arrow_s3_file_io.cc:
##########
@@ -192,7 +195,7 @@ class ArrowS3FileIO final : public FileIO, public
SupportsStorageCredentials {
public:
ArrowS3FileIO(std::shared_ptr<::arrow::fs::FileSystem> arrow_fs,
std::unordered_map<std::string, std::string>
default_properties)
- : default_file_io_(std::move(arrow_fs)),
+ :
default_file_io_(std::make_shared<ArrowFileSystemFileIO>(std::move(arrow_fs))),
Review Comment:
@wgtmac MatchDelegate now returns a shared_ptr, so the default delegate is
one too, which keeps a single owning return type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
