swanandx commented on code in PR #3277:
URL: https://github.com/apache/iceberg-rust/pull/3277#discussion_r4110365842
##########
crates/iceberg/src/arrow/reader/pipeline.rs:
##########
@@ -91,14 +91,24 @@ impl ArrowReader {
.try_flatten(),
)
} else {
+ // Open each file inside the stream that reads it. A file opened
+ // ahead of the flatten can sit unread, and on one HTTP/2
+ // connection an unread response stops the server sending for
+ // every other read on that connection.
Box::pin(
tasks
- .map_ok(move |task| task_reader.clone().process(task))
+ .map_ok(move |task| {
+ task_reader
+ .clone()
+ .process(task)
+ .try_flatten_stream()
+ // `try_flatten_unordered` needs `Unpin`.
Review Comment:
removed it, thanks for pointing out!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
