Dzeri96 commented on code in PR #17029:
URL: https://github.com/apache/iceberg/pull/17029#discussion_r4102495073
##########
docs/docs/spark-configuration.md:
##########
@@ -63,22 +63,23 @@ Iceberg supplies two implementations:
Both catalogs are configured using properties nested under the catalog name.
Common configuration properties for Hive and Hadoop are:
-| Property | Values
| Description
|
-| --------------------------------------------------
|----------------------------------------------------|----------------------------------------------------------------------------------------------------------------------------------------------------------------------|
-| spark.sql.catalog._catalog-name_.type | `hive`, `hadoop`,
`rest`, `glue`, `jdbc` or `nessie` | The underlying Iceberg catalog
implementation, `HiveCatalog`, `HadoopCatalog`, `RESTCatalog`, `GlueCatalog`,
`JdbcCatalog`, `NessieCatalog` or left unset if using a custom catalog |
-| spark.sql.catalog._catalog-name_.catalog-impl |
| The custom Iceberg catalog implementation. If `type` is null,
`catalog-impl` must not be null. |
+| Property | Values
| Description
|
+|---------------------------------------------------------------|----------------------------------------------------|----------------------------------------------------------------------------------------------------------------------------------------------------------------------|
+| spark.sql.catalog._catalog-name_.type | `hive`,
`hadoop`, `rest`, `glue`, `jdbc` or `nessie` | The underlying Iceberg catalog
implementation, `HiveCatalog`, `HadoopCatalog`, `RESTCatalog`, `GlueCatalog`,
`JdbcCatalog`, `NessieCatalog` or left unset if using a custom catalog |
+| spark.sql.catalog._catalog-name_.catalog-impl |
| The custom Iceberg catalog implementation. If `type` is
null, `catalog-impl` must not be null. |
| spark.sql.catalog._catalog-name_.io-impl |
| The custom FileIO implementation. |
| spark.sql.catalog._catalog-name_.metrics-reporter-impl |
| The custom MetricsReporter implementation. |
-| spark.sql.catalog._catalog-name_.default-namespace | default
| The default current namespace for the catalog |
-| spark.sql.catalog._catalog-name_.uri | thrift://host:port
| Hive metastore URL for hive typed catalog, REST URL for REST typed
catalog |
-| spark.sql.catalog._catalog-name_.warehouse |
hdfs://nn:8020/warehouse/path | Base path for the warehouse directory |
-| spark.sql.catalog._catalog-name_.cache-enabled | `true` or `false`
| Whether to enable catalog cache, default value is `true` |
+| spark.sql.catalog._catalog-name_.default-namespace | default
| The default current namespace for the `SparkCatalog`. |
+| spark.sql.catalog._catalog-name_.defaultDatabase | default
| The default current namespace for the `SparkSessionCatalog`.
|
Review Comment:
What do you mean? In this PR, the `default-namespace` key still works for
the SparkCatalog, which is what I'm trying to change in the other PR, by
unifying both with one key.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
