kevinjqliu commented on code in PR #18247:
URL: https://github.com/apache/iceberg/pull/18247#discussion_r4100581512
##########
aws/src/integration/java/org/apache/iceberg/aws/s3/TestS3FileIO.java:
##########
@@ -136,16 +136,12 @@ public class TestS3FileIO {
"s3.delete.batch-size",
Integer.toString(batchDeletionSize));
- protected MinIOContainer createMinIOContainer() {
- MinIOContainer container = MinioUtil.createContainer();
+ private static GenericContainer<?> startObjectStore() {
+ GenericContainer<?> container = ObjectStoreUtil.createContainer();
container.start();
return container;
}
- protected boolean legacyMd5PluginEnabled() {
Review Comment:
we should track this and add it back when rustfs supports md5
##########
site/docs/integrations/daft.md:
##########
Review Comment:
made changes to include the docs too
##########
site/docs/spark-quickstart.md:
##########
@@ -72,41 +72,46 @@ services:
- AWS_REGION=us-east-1
- CATALOG_WAREHOUSE=s3://warehouse/
- CATALOG_IO__IMPL=org.apache.iceberg.aws.s3.S3FileIO
- - CATALOG_S3_ENDPOINT=http://minio:9000
- minio:
- image: quay.io/minio/minio
- container_name: minio
+ - CATALOG_S3_ENDPOINT=http://object-store:9000
+ - CATALOG_S3_PATH__STYLE__ACCESS=true
+ # tabulario/spark-iceberg expects virtual-hosted-style S3 at
http://minio:9000
Review Comment:
we should follow up and replace `tabulario/spark-iceberg` with
`iceberg-rest-fixture`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
