danielcweeks commented on code in PR #18250:
URL: https://github.com/apache/iceberg/pull/18250#discussion_r4099836534
##########
spark/v4.2/spark/src/main/java/org/apache/iceberg/spark/SparkTypeToType.java:
##########
@@ -75,7 +93,7 @@ private int getNextId() {
public Type struct(StructType struct, List<Type> types) {
StructField[] fields = struct.fields();
List<Types.NestedField> newFields =
Lists.newArrayListWithExpectedSize(fields.length);
- boolean isRoot = root == struct;
+ boolean isRoot = root.equals(struct);
Review Comment:
This change in the equality check is necessary since the
`TableInfo::schmea()` now produces a new object based on the column
representation, so reference equality no longer holds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
