kevinjqliu commented on code in PR #2055:
URL: https://github.com/apache/iceberg-go/pull/2055#discussion_r4099220361
##########
internal/recipe/Dockerfile:
##########
@@ -19,6 +19,7 @@ RUN pip3 install -q ipython
RUN pip3 install pyiceberg[s3fs,hive]
RUN pip3 install pyarrow
+COPY spark-defaults.conf ${SPARK_HOME}/conf/spark-defaults.conf
Review Comment:
no need for
```
RUN sed -i 's|http://minio:9000|http://object-store:9000|g'
${SPARK_HOME}/conf/spark-defaults.conf
```
follow spark 4 dockerfile convention
https://github.com/apache/iceberg-go/blob/85121cbde006091263c8035b90bd76a34b3d7460/internal/recipe/Dockerfile.spark4#L39
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
