dhruvarya-db commented on code in PR #3268:
URL: https://github.com/apache/iceberg-rust/pull/3268#discussion_r4098459440
##########
crates/iceberg/src/arrow/delete_filter.rs:
##########
@@ -168,17 +168,22 @@ impl DeleteFilter {
&self,
file_path: &str,
) -> Option<Predicate> {
- let notifier = {
+ // Create the `Notified` while holding the read lock. The read lock
ensures that
+ // when we go inside it, either the state is already at Loaded or it
is still at
+ // Loading AND `notify_waiters()` has not been called yet. Any
`Notified` created
+ // before the invocation of `notify_waiters()` will be notified by it
even if
+ // `await` has not been called on it yet.
Review Comment:
My bad. Your suggestion looks a bit better, updated the PR with it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
