danielcweeks commented on code in PR #18216:
URL: https://github.com/apache/iceberg/pull/18216#discussion_r4098467263
##########
open-api/src/testFixtures/java/org/apache/iceberg/rest/RESTServerExtension.java:
##########
@@ -80,6 +80,10 @@ public void beforeAll(ExtensionContext extensionContext)
throws Exception {
}
this.client = RCKUtils.initCatalogClient(config);
+ } else if (findFreePort) {
+ // no local server was started, so there is no port to resolve the
placeholder to; drop it so
+ // that callers merging config() into client properties do not point a
client at port 0
+ config.remove(RESTCatalogServer.REST_PORT);
Review Comment:
@Kurtiscwright I'm a little concerned this this makes it so that you can't
run the RCK tests against an external server. The RCK allows running in a
non-local mode, but the client still needs the correct port configured, but
this looks like we're removing it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
