anoopj commented on code in PR #17541: URL: https://github.com/apache/iceberg/pull/17541#discussion_r4098792075
########## core/src/main/java/org/apache/iceberg/FilePlanner.java: ########## @@ -0,0 +1,259 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg; + +import java.io.IOException; +import java.io.UncheckedIOException; +import java.util.List; +import java.util.Map; +import java.util.concurrent.ExecutorService; +import org.apache.iceberg.expressions.Expression; +import org.apache.iceberg.expressions.Expressions; +import org.apache.iceberg.expressions.ResidualEvaluator; +import org.apache.iceberg.io.CloseableIterable; +import org.apache.iceberg.io.FileIO; +import org.apache.iceberg.metrics.ScanMetrics; +import org.apache.iceberg.metrics.ScanMetricsUtil; +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; +import org.apache.iceberg.relocated.com.google.common.collect.ImmutableList; +import org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap; +import org.apache.iceberg.relocated.com.google.common.collect.Lists; +import org.apache.iceberg.relocated.com.google.common.collect.Maps; +import org.apache.iceberg.util.ParallelIterable; + +/** + * Plans {@link FileScanTask}s from a V4 root manifest. + * + * <p>Emits a task for each live {@code DATA} entry and expands {@code DATA_MANIFEST} entries into + * their leaf manifests. A data file's colocated deletion vector is attached to its task as a {@link + * DeleteFile}. + */ +class FilePlanner { + private static final DeleteFile[] NO_DELETES = new DeleteFile[0]; + + private final FileIO io; + private final ManifestFile root; + private final Schema tableSchema; + private final Map<Integer, PartitionSpec> specsById; + private final String tableLocation; + private final Expression dataFilter; + private final boolean ignoreResiduals; + private final boolean caseSensitive; + private final ScanMetrics scanMetrics; + private final ExecutorService executorService; + private final Map<Integer, TaskContext> taskContextsBySpec = Maps.newConcurrentMap(); + + private FilePlanner( + FileIO io, + ManifestFile root, + Schema tableSchema, + Map<Integer, PartitionSpec> specsById, + String tableLocation, + Expression dataFilter, + boolean ignoreResiduals, + boolean caseSensitive, + ScanMetrics scanMetrics, + ExecutorService executorService) { + this.io = io; + this.root = root; + this.tableSchema = tableSchema; + this.specsById = specsById; + this.tableLocation = tableLocation; + this.dataFilter = dataFilter; + this.ignoreResiduals = ignoreResiduals; + this.caseSensitive = caseSensitive; + this.scanMetrics = scanMetrics; + this.executorService = executorService; + } + + static Builder builder( + FileIO io, ManifestFile root, Schema tableSchema, Map<Integer, PartitionSpec> specsById) { + return new Builder(io, root, tableSchema, specsById); + } + + CloseableIterable<FileScanTask> planFiles() { + List<TrackedFile> rootDataFiles = Lists.newArrayList(); + List<ManifestFile> leafManifests = Lists.newArrayList(); + + try (CloseableIterable<TrackedFile> rootEntries = reader(root)) { + for (TrackedFile entry : rootEntries) { + switch (entry.contentType()) { + case DATA: + rootDataFiles.add(entry); + break; + case DATA_MANIFEST: + leafManifests.add(TrackedFileAdapters.asManifestFile(entry)); + break; + case DELETE_MANIFEST: + throw new UnsupportedOperationException("v3 and earlier deletes are not yet supported"); + default: + throw new UnsupportedOperationException( + "Unsupported file type in root manifest: " + entry.contentType()); + } + } + } catch (IOException e) { + throw new UncheckedIOException("Failed to close root manifest: " + root.path(), e); + } + + List<CloseableIterable<TrackedFile>> leafPlanTasks = Lists.newArrayList(); + for (ManifestFile leaf : leafManifests) { + leafPlanTasks.add(reader(leaf)); + } + + CloseableIterable<TrackedFile> leafFiles = + executorService != null && leafManifests.size() > 1 + ? new ParallelIterable<>(leafPlanTasks, executorService) + : CloseableIterable.concat(leafPlanTasks); + + CloseableIterable<TrackedFile> files = + CloseableIterable.concat( + ImmutableList.of(CloseableIterable.withNoopClose(rootDataFiles), leafFiles)); + + CloseableIterable<DataFile> dataFiles = + CloseableIterable.transform(files, file -> TrackedFileAdapters.asDataFile(file, specsById)); + + return CloseableIterable.transform(dataFiles, this::createTask); + } + + private CloseableIterable<TrackedFile> reader(ManifestFile manifest) { + V4ManifestReader.Builder builder = + V4ManifestReader.builder(manifest, io, tableSchema, specsById) + .forScanPlanning() + .filter(dataFilter) + .caseSensitive(caseSensitive) + .scanMetrics(scanMetrics); + if (tableLocation != null) { + builder.tableLocation(tableLocation); + } + + return builder.build(); + } + + private FileScanTask createTask(DataFile dataFile) { + TaskContext context = + taskContextsBySpec.computeIfAbsent(dataFile.specId(), this::newTaskContext); + + DeleteFile[] deletes = NO_DELETES; + if (dataFile.deletionVector() != null) { + DeleteFile dv = TrackedFileAdapters.asDVDeleteFile(dataFile); + ScanMetricsUtil.indexedDeleteFile(scanMetrics, dv); + deletes = new DeleteFile[] {dv}; + } + + ScanMetricsUtil.fileTask(scanMetrics, dataFile, deletes); + + return new BaseFileScanTask( + dataFile, deletes, context.schemaAsString, context.specAsString, context.residuals); + } + + private TaskContext newTaskContext(int specId) { + PartitionSpec spec = specsById.get(specId); + Expression filter = ignoreResiduals ? Expressions.alwaysTrue() : dataFilter; + return new TaskContext( + SchemaParser.toJson(spec.schema()), + PartitionSpecParser.toJson(spec), + ResidualEvaluator.of(spec, filter, caseSensitive)); + } + + /** Per-spec task inputs computed once and shared across all files of a spec. */ + private static class TaskContext { + private final String schemaAsString; + private final String specAsString; + private final ResidualEvaluator residuals; + + private TaskContext(String schemaAsString, String specAsString, ResidualEvaluator residuals) { + this.schemaAsString = schemaAsString; + this.specAsString = specAsString; + this.residuals = residuals; + } + } + + static class Builder { Review Comment: We don't have other callers yet. I chose builder because it is consistent with the v4 classes, other than that, there was no strong reason. I can switch to a fluent API similar to what `ManifestGroup` provides. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
