Copilot commented on code in PR #3273:
URL: https://github.com/apache/iceberg-rust/pull/3273#discussion_r4096392885
##########
dev/docker-compose.yaml:
##########
@@ -25,51 +25,42 @@ networks:
services:
#
=============================================================================
- # MinIO - S3-compatible storage (shared by all tests)
+ # RustFS - S3-compatible storage (shared by all tests)
#
=============================================================================
- minio:
- image: quay.io/minio/minio:RELEASE.2025-05-24T17-08-30Z
+ rustfs:
+ image: rustfs/rustfs:1.0.0
environment:
- - MINIO_ROOT_USER=admin
- - MINIO_ROOT_PASSWORD=password
- - MINIO_DOMAIN=minio
- hostname: minio
+ - RUSTFS_ACCESS_KEY=admin
+ - RUSTFS_SECRET_KEY=password
+ - RUSTFS_SERVER_DOMAINS=rustfs
+ hostname: rustfs
networks:
iceberg_test:
# Add aliases for virtual-hosted style bucket access
aliases:
- - icebergdata.minio
- - warehouse.minio
- - bucket1.minio
+ - icebergdata.rustfs
+ - warehouse.rustfs
+ - bucket1.rustfs
ports:
- "9000:9000"
- "9001:9001"
- command: ["server", "/data", "--console-address", ":9001"]
healthcheck:
- test: ["CMD", "mc", "ready", "local"]
+ test: ["CMD", "curl", "-f", "http://localhost:9000/health/ready";]
interval: 5s
timeout: 5s
retries: 5
- # MinIO client - creates buckets for tests
- mc:
+ # Creates buckets for tests
+ create-buckets:
depends_on:
- minio:
+ rustfs:
condition: service_healthy
- image: quay.io/minio/mc:RELEASE.2025-05-21T01-59-54Z
- environment:
- - AWS_ACCESS_KEY_ID=admin
- - AWS_SECRET_ACCESS_KEY=password
- - AWS_REGION=us-east-1
+ image: rustfs/rustfs:1.0.0
entrypoint: >
/bin/sh -c "
- /usr/bin/mc alias set minio http://minio:9000 admin password;
- /usr/bin/mc mb --ignore-existing minio/icebergdata;
- /usr/bin/mc mb --ignore-existing minio/warehouse;
- /usr/bin/mc mb --ignore-existing minio/bucket1;
- /usr/bin/mc policy set public minio/icebergdata;
- /usr/bin/mc policy set public minio/warehouse;
- /usr/bin/mc policy set public minio/bucket1;
+ curl -fsS --aws-sigv4 aws:amz:us-east-1:s3 -u admin:password -X PUT
http://rustfs:9000/icebergdata;
+ curl -fsS --aws-sigv4 aws:amz:us-east-1:s3 -u admin:password -X PUT
http://rustfs:9000/warehouse;
+ curl -fsS --aws-sigv4 aws:amz:us-east-1:s3 -u admin:password -X PUT
http://rustfs:9000/bucket1;
Review Comment:
These commands use `;`, so a failed `curl -f` does not stop the shell: it
continues to the success message and `tail -f /dev/null`. Compose therefore
treats `create-buckets` as running even when a bucket was not created, and
`make docker-up` can report success before tests fail later with misleading S3
errors. Chain the requests (or enable `set -e`) so provisioning failure makes
the service fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
