gaborkaszab commented on code in PR #17533:
URL: https://github.com/apache/iceberg/pull/17533#discussion_r4093539589
##########
format/spec.md:
##########
@@ -1295,18 +1297,19 @@ If a table has no deletes or only deletion vectors,
implementations are encourag
#### Encryption Keys
-Keys used for table encryption can be tracked in table metadata as a list
named `encryption-keys`. The schema of each key is a struct with the following
fields:
+Keys used for table encryption can be tracked in table metadata as a list
named `encryption-keys`, or stored directly in the metadata of the file they
encrypt. The schema of each key is a struct with the following fields:
=== "v1 - v3"
| v1 | v2 | v3 | Field name | Type
| Description |
|----|----|------------|-------------------------------|-----------------------|-------------|
- | | | _required_ | **`key-id`** | `string`
| ID of the encryption key |
+ | | | _optional_ | **`key-id`** | `string`
| ID of the encryption key [2] |
Review Comment:
I'm not entirely sure we can change this to optional in V3. The motivation
is that now we refer to this structure from stat files from v1-v3 and there
it's wasteful to have a `key-id` and making it optional makes sense if the
compatibility rule of the spec allows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
