RussellSpitzer commented on PR #17808: URL: https://github.com/apache/iceberg/pull/17808#issuecomment-5805180024
Closing in favor of the separate-type design (design B), which the discussion on #17919 settled on. This PR made `FileType` a subclass of `StructType` so that `typeId()` returned `STRUCT`. The alternative gives `file` its own `TypeID.FILE` and has visitors fall back to struct behavior by default, which keeps engine integrations working without a change while still letting code that cares distinguish a file from a struct. That approach is being landed as a series of small PRs starting with #18229. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
