anoopj commented on code in PR #18212:
URL: https://github.com/apache/iceberg/pull/18212#discussion_r4087481484
##########
core/src/test/java/org/apache/iceberg/TestManifestInfoStruct.java:
##########
@@ -484,17 +609,20 @@ void builderAllowsFilesWithoutRows() {
.existingFilesCount(5)
.deletedFilesCount(5)
.replacedFilesCount(5)
+ .modifiedFilesCount(5)
.addedRowsCount(0L)
.existingRowsCount(0L)
.deletedRowsCount(0L)
.replacedRowsCount(0L)
+ .modifiedRowsCount(0L)
.minSequenceNumber(0L)
.build();
assertThat(info.addedFilesCount()).isEqualTo(5);
assertThat(info.existingFilesCount()).isEqualTo(5);
assertThat(info.deletedFilesCount()).isEqualTo(5);
assertThat(info.replacedFilesCount()).isEqualTo(5);
+ assertThat(info.modifiedFilesCount()).isEqualTo(5);
Review Comment:
Consider adding an assertion for `modifiedRowsCount` also? we are setting it
in the builder
##########
core/src/main/java/org/apache/iceberg/ManifestInfo.java:
##########
@@ -45,7 +48,10 @@ interface ManifestInfo {
514, "deleted_rows_count", Types.LongType.get(), "Number of rows in
deleted files");
Types.NestedField REPLACED_ROWS_COUNT =
Types.NestedField.required(
- 521, "replaced_rows_count", Types.LongType.get(), "Number of rows in
replaced files");
+ 524, "replaced_rows_count", Types.LongType.get(), "Number of rows in
replaced files");
+ Types.NestedField MODIFIED_ROWS_COUNT =
Review Comment:
The new fields aren't covered in the round trip. We might need to update the
comparators util
[here](https://github.com/apache/iceberg/blob/bb9faedfb22ce7763159b731f5c7dc63936d771b/core/src/test/java/org/apache/iceberg/V4TestComparators.java#L113-L124).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
