rdblue commented on code in PR #18225:
URL: https://github.com/apache/iceberg/pull/18225#discussion_r4086034573
##########
core/src/main/java/org/apache/iceberg/V4ManifestReader.java:
##########
@@ -59,7 +59,12 @@ class V4ManifestReader extends CloseableGroup implements
CloseableIterable<Track
static Builder builder(
ManifestFile manifest, FileIO io, Schema tableSchema, Map<Integer,
PartitionSpec> specsById) {
- return new Builder(manifest, io, tableSchema, specsById);
+ return new Builder(manifest, io, tableSchema, specsById, false /*
committed */);
+ }
+
+ static Builder uncommitted(
Review Comment:
I chose to use a factory method to set this state so that we can more easily
keep this internal-only. An `uncommitted()` method on the builder could be
package-private, but I think that is more likely to be updated to public when
the other configuration methods are.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
