kevinjqliu commented on code in PR #18218: URL: https://github.com/apache/iceberg/pull/18218#discussion_r4085899667
########## gcp-bundle/LICENSE: ########## @@ -452,6 +452,13 @@ License: Apache License, Version 2.0 - https://www.apache.org/licenses/LICENSE-2 -------------------------------------------------------------------------------- +This product bundles Caffeine by Ben Manes (bundled by GCS Analytics). + +Project URL: https://github.com/ben-manes/caffeine +License: Apache License, Version 2.0 - https://www.apache.org/licenses/LICENSE-2.0 Review Comment: the `(bundled by GCS Analytics)` part is not necessary unless its a transitive dependency of another dep ########## gcp-bundle/LICENSE: ########## @@ -452,6 +452,13 @@ License: Apache License, Version 2.0 - https://www.apache.org/licenses/LICENSE-2 -------------------------------------------------------------------------------- +This product bundles Caffeine by Ben Manes (bundled by GCS Analytics). + +Project URL: https://github.com/ben-manes/caffeine +License: Apache License, Version 2.0 - https://www.apache.org/licenses/LICENSE-2.0 Review Comment: ```suggestion This product bundles Caffeine by Ben Manes. Copyright: 2014-2020 Ben Manes and contributors Project URL: https://github.com/ben-manes/caffeine License: Apache License, Version 2.0 - https://www.apache.org/licenses/LICENSE-2.0 ``` nit align this with other entries - https://github.com/apache/iceberg/blob/89a6a8776a251f5113770697b2c1d634c1f5fae0/spark/v4.1/spark-runtime/LICENSE#L842-L846 - https://github.com/apache/iceberg/blob/89a6a8776a251f5113770697b2c1d634c1f5fae0/aws-bundle/LICENSE#L284-L288 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
