yidawang-shopify commented on code in PR #17668:
URL: https://github.com/apache/iceberg/pull/17668#discussion_r4085214026


##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/IcebergSink.java:
##########
@@ -1026,10 +1082,15 @@ private DataStream<RowData> 
distributeDataStreamByHashDistributionMode(
     }
   }
 
+  /** The configured {@code write-parallelism}, or null to follow the input's 
parallelism. */
+  public Integer writeParallelism() {
+    return writeParallelism;
+  }

Review Comment:
   This is essentially because lineage is only enable for V2, which goes 
through a different path of obtaining the parallelism setting. 
   
   I have cleaned up this a bit. Now, I follow the convention of 
`inferParallelism` to get this number and pass it to the source. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to