rambleraptor commented on code in PR #4009:
URL: https://github.com/apache/iceberg-python/pull/4009#discussion_r4084724549
##########
tests/avro/test_resolver.py:
##########
@@ -418,3 +421,30 @@ def test_writer_missing_optional_in_read_schema() -> None:
expected = StructWriter(field_writers=((None,
OptionWriter(option=StringWriter())),))
assert actual == expected
+
+
[email protected]("decoder_class", [StreamingBinaryDecoder,
CythonBinaryDecoder])
Review Comment:
There's a list of AVAILABLE_DECODERS in `tests/avro/test_reader.py` that we
should try to reuse
That'll involve moving that list to some shared file, but that way we can
have future tests all share the same list of decoders.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
