Guosmilesmile commented on code in PR #18144:
URL: https://github.com/apache/iceberg/pull/18144#discussion_r4080963633
##########
flink/v2.3/flink/src/main/java/org/apache/iceberg/flink/FlinkDynamicTableFactory.java:
##########
@@ -132,6 +134,8 @@ public Set<ConfigOption<?>> optionalOptions() {
options.add(FlinkCreateTableOptions.CATALOG_TABLE);
options.add(FlinkCreateTableOptions.USE_DYNAMIC_ICEBERG_SINK);
options.add(FlinkCreateTableOptions.DYNAMIC_RECORD_GENERATOR_IMPL);
+ options.add(LookupOptions.CACHE_TYPE);
Review Comment:
Not strictly needed for behavior, but I kept it as a declaration.
optionalOptions() is the only place that lists the supported options, and once
the factory starts using TableFactoryHelper.validate(), an undeclared
lookup.cache would fail. Happy to drop it if you'd rather.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
