gaborkaszab commented on PR #18198: URL: https://github.com/apache/iceberg/pull/18198#issuecomment-5792389759
Hey, @mxm , @nastra , @stevenzwu I see you have touched this area of the code before, so I added you as optional reviewers here. Context: The purpose of the PR is two fold: 1) Currently, this class creates input files without providing the length resulting an extra RPC. Fixes that by using EncryptionFileIO.bulkDecryt() 2) Make the class general enough to be used across all the readers, like `GenericReader` Sparks readers, etc. 3) For reading files with column files the current proposal is to introduce an extra layer of abstraction as a `DataFileReadBuilder` on top of the file format API. This class could be an input to that layer to provide `InputFile`s to the readers underneath. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
