YuangGao commented on PR #3179: URL: https://github.com/apache/iceberg-rust/pull/3179#issuecomment-5788227184
thanks for the reviews, updated/confirmed the following: - OpenDalStorage::S3 is now `#[non_exhaustive]`, so the next S3 option isn't another breaking bump. `pub(crate) `isn't allowed on a variant field (E0449). I skipped the pub const for the default: with the variant closed there's no downstream constructor left to hardcode 33_554_432. - confirmed he integration tests do run in CI. `Tests (default) `starts MinIO via make docker-up, then cargo nextest run --all-targets --all-features --workspace - The property doc now cites `MULTIPART_SIZE_DEFAULT` and notes Java's int storage and the sub-2 GB javadoc guidance. - The 32-bit comment spells out the effective `usize::MAX` ceiling. - `upload_part_count` shares creds, region and bucket with the other tests, and now carries the `RetryLayer` the storage under test uses. @laskoviymishka @CTTY ready for another look when you have a chance -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
