RussellSpitzer commented on code in PR #17944:
URL: https://github.com/apache/iceberg/pull/17944#discussion_r4075691943
##########
parquet/src/test/java/org/apache/iceberg/parquet/TestParquet.java:
##########
@@ -658,6 +661,31 @@ public void testAvroWriterRejectsVariantType() {
.hasMessage("Avro writer does not support variant types");
}
+ @Test
+ void writesVariantWithDefaultAvroWriter() throws IOException {
Review Comment:
nit: but it definitely makes it look like we both Reject variants (see above
test case) and accept them (this test). We should probably make the names a
little more clear about what we are actually trying to do here.
maybe we rename them
```java
parquetAvroValueWriterRejectsVariant()
parquetAvroDefaultModelWritesVariant()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
