shoemoney commented on PR #2034: URL: https://github.com/apache/iceberg-go/pull/2034#issuecomment-5765184110
@laskoviymishka Thanks — you were right, the write path was never reached. All four items are addressed in 731e48b: - `newPartitionFieldStat` now has a `TimestampNsType, TimestampTzNsType` arm routing through a new `convertPartitionTimestampNano`, exactly as you sketched. - `TestNewManifestWriterV3NanosecondPartition` now `Add`s data-file entries (including a negative pre-epoch value) and calls `ToManifestFile`, so the partition-summary bounds are actually serialized and asserted as little-endian int64 nanoseconds. It fails against the previous commit. - The two ns arms are mirrored into the `partitionTypeToAvroSchemaNonNullable` test helper, and `TestNanosecondPartitionAvroSchema` now round-trips through the non-nullable schema too. - Dropped the unused `TimestampNsSchema`/`TimestampTzNsSchema` compiled vars. I left `convertLogicalTypeValue` alone since, as you noted, the wire output is already correct there and it's orthogonal to this fix. Ready for another pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
