badalprasadsingh commented on PR #2016: URL: https://github.com/apache/iceberg-go/pull/2016#issuecomment-5764066567
There was a problem as RowDelta now rejects Parquet pos-deletes on v3 tables, which broke four tests that committed one: - `TestRowDeltaRemoveDeletesRejectsNonDV`, `TestScanPruningWithPositionalDeletes`, `TestScanRowLineagePreservedThroughPositionalDeletes`: these need the delete on a v3 table. The only real way to get there is to commit it on v2 and then upgrade, so the tests now do exactly that. - The two scan tests also commit a no-op Delete. That creates the first v3 snapshot, which gives the existing rows a `_row_id`. - `TestDataFileFromMetadata_EndToEndRowDelta`: nothing v3-specific, so it now runs on v2. Happy to change this if there's a better approach :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
