raunaqmorarka commented on PR #18188: URL: https://github.com/apache/iceberg/pull/18188#issuecomment-5758943333
> Isn't this solving the same as https://github.com/apache/iceberg/pull/17832? Different problem. #17832 restores the lazy snapshots supplier and the `snapshots` query parameter on refresh in `refs` mode. This PR makes refresh conditional with `If-None-Match` so an unchanged table gets a 304 and no metadata body is parsed. Both change `refresh()` and `updateCurrentMetadata`, so one will need a rebase after the other merges, but they are independent. They also fit together: with #17832 the refresh request carries the same query parameters as the load, so the ETag from loadTable matches on the first refresh, and a 304 leaves `current()` and its snapshots supplier untouched. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
