JeonDaehong commented on code in PR #18027:
URL: https://github.com/apache/iceberg/pull/18027#discussion_r4062498831
##########
core/src/test/java/org/apache/iceberg/deletes/TestBitmapPositionDeleteIndex.java:
##########
@@ -235,4 +366,60 @@ private List<Long> collect(PositionDeleteIndex index) {
index.forEach(positions::add);
return positions;
}
+
+ private static List<Long> collect(PositionDeleteIndex index, long posStart,
long posEnd) {
Review Comment:
Renamed to `positionsInRange`. Parameters now match the other helper too.
##########
core/src/test/java/org/apache/iceberg/deletes/TestRoaringPositionBitmap.java:
##########
@@ -350,6 +350,132 @@ public void testAddAllSparseBitmaps() {
assertThat(bitmap1.cardinality()).isEqualTo(4);
}
+ @TestTemplate
+ public void testForEachInRange() {
+ RoaringPositionBitmap bitmap = new RoaringPositionBitmap();
+ bitmap.setRange(10L, 20L);
+
+ // the beginning is inclusive and the end is exclusive
Review Comment:
Removed.
##########
core/src/test/java/org/apache/iceberg/deletes/TestRoaringPositionBitmap.java:
##########
@@ -587,6 +713,13 @@ private void assertRandomPositions(RoaringPositionBitmap
bitmap, Set<Long> posit
}
}
+ private static List<Long> collectInRange(
Review Comment:
Renamed to `positionsInRange` as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
