jopdorp commented on PR #2185: URL: https://github.com/apache/iceberg-rust/pull/2185#issuecomment-5733128473
We need overwrite for a service we build on iceberg-rust with a Lakekeeper catalog, so I went through the review and did the fixes on top of your branch: glitchy/iceberg-rust#4. It merges main first (the `SnapshotProducer::new` and manifest reader changes), then one commit per review point, each with a test that fails on the current code. Two things worth a look: the operation now follows Java (append / delete / overwrite by what the commit actually does), and a delete of a path the table doesn't have is rejected instead of ignored, again as in Java. Happy to adjust anything. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
