sgg commented on code in PR #2015:
URL: https://github.com/apache/iceberg-go/pull/2015#discussion_r4048552431


##########
table/partitioned_fanout_writer.go:
##########
@@ -397,6 +397,66 @@ func newPartitionExtractionPlan(spec 
iceberg.PartitionSpec, schema *iceberg.Sche
        }, nil
 }
 
+// resolveArrowColumnPath resolves a dot-joined nested field name into a path 
of Arrow field indices.
+func resolveArrowColumnPath(recordSchema *arrow.Schema, colName string) 
([]int, bool) {
+       segments := strings.Split(colName, ".")

Review Comment:
   Oof this is a good catch; it didn't even occur to me that a `.` was a legal 
character in a field name!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to