xanderbailey commented on code in PR #3236:
URL: https://github.com/apache/iceberg-rust/pull/3236#discussion_r4045328153
##########
crates/iceberg/src/writer/file_writer/parquet_writer.rs:
##########
@@ -746,6 +746,7 @@ impl ArrowAsyncFileWriter for AsyncFileWriter {
self.0
.close()
.await
+ .map(|_| ())
Review Comment:
For what it's worth, Java doesn't use the standard key metadata for parquet
truncation. I think PME does this internally, Java does still write the parquet
length into the StandardKeyMetadata.fileLength, it's just not read.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
