rdblue commented on code in PR #18060:
URL: https://github.com/apache/iceberg/pull/18060#discussion_r4039568164
##########
core/src/test/java/org/apache/iceberg/TestFieldStatsStruct.java:
##########
@@ -232,7 +232,11 @@ public void fieldStatsProjection() {
Named.of("Java", TestHelpers::roundTripSerialize),
Named.of("Kryo", TestHelpers.KryoHelpers::roundTripSerialize),
Named.of("InternalData",
TestFieldStatsStruct::roundTripInternalData),
- Named.of("FieldStats#copy", FieldStatsStruct::copy));
+ Named.of("FieldStats#copy", FieldStatsStruct::copy),
+ // copy first, then serialize: geo bounds are deep-copied into a
StructCopy, which must
+ // itself survive Java serialization
Review Comment:
This is too verbose. How about "Verify that copies are also serializable".
And if you're checking that, then this should also test Kryo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
