rdblue commented on code in PR #17533:
URL: https://github.com/apache/iceberg/pull/17533#discussion_r4029282040
##########
format/spec.md:
##########
@@ -1216,7 +1214,8 @@ Statistics files metadata within `statistics` table
metadata field is a struct w
| _required_ | _required_ | **`statistics-path`** | `string`
| Path of the statistics file. See [Puffin file
format](puffin-spec.md). |
| _required_ | _required_ | **`file-size-in-bytes`** | `long`
| Size of the statistics file. |
| _required_ | _required_ | **`file-footer-size-in-bytes`** | `long`
| Total size of the statistics file's footer (not the footer payload
size). See [Puffin file format](puffin-spec.md) for footer definition. |
- | _optional_ | _optional_ | **`key-metadata`** |
| Base64-encoded implementation-specific key metadata for encryption. |
+ | _optional_ | _optional_ | **`key-metadata`** | `string`
| Base64-encoded implementation-specific key metadata for encryption.
(**Deprecated**: use `key-id` instead) |
Review Comment:
I think there is still a problem in that we are mixing file-level keys with
table-level keys. The keys table is intended to be a small set of keys that are
reused and occasionally rotated, not file-specific.
@ggershinsky, how should we handle these? Do we need a way to store
encrypted key metadata? What I'm thinking is that we keep `key-metadata` but
add an optional `key-id` that is used to encrypt the stats file key?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
