moomindani opened a new pull request, #18145: URL: https://github.com/apache/iceberg/pull/18145
## Summary Follow-up to #16798, applying to `decimal` what #16799 did for `geography`. #16798 added the sentence that the type strings in this table are the canonical serialized forms, and its description gives the canonical decimal form as `decimal(P, S)`, but it left the decimal row itself unchanged: the template still reads `"decimal(<P>,<S>)"` and the examples still show both spacings. This updates the row to match — one template and one example, both spaced. Java writes that form: [`SchemaParser` writes `type.toString()`](https://github.com/apache/iceberg/blob/main/core/src/main/java/org/apache/iceberg/SchemaParser.java#L145) and [`DecimalType.toString()` formats `decimal(%d, %d)`](https://github.com/apache/iceberg/blob/main/api/src/main/java/org/apache/iceberg/types/Types.java#L549). PyIceberg emits the same. Reader tolerance for the unspaced form is unchanged — that is stated by the sentence #16798 added. Noticed while working on conformance fixtures for apache/iceberg-verification, where a fixture has to name one canonical form per type string. ## Testing - `git diff --check` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
