wombatu-kun commented on PR #16791: URL: https://github.com/apache/iceberg/pull/16791#issuecomment-5697614974
It is still there - e810a51730 kept the iterator reuse and only dropped the two explanatory comments, which #18133's javadoc now covers. `elements()` and `pairs()` reset a single per-writer instance and hand that same instance back on every call: https://github.com/apache/iceberg/blob/e810a5173045e5059c1648a842783efbdf7c4ff0/flink/v2.3/flink/src/main/java/org/apache/iceberg/flink/data/FlinkParquetWriters.java#L526-L530 https://github.com/apache/iceberg/blob/e810a5173045e5059c1648a842783efbdf7c4ff0/flink/v2.3/flink/src/main/java/org/apache/iceberg/flink/data/FlinkParquetWriters.java#L585-L589 `EntryIterator`'s `ReusableEntry` is allocated once as well, so there is nothing left to change here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
