Sruhvx-jpg commented on PR #3165: URL: https://github.com/apache/iceberg-rust/pull/3165#issuecomment-5698627683
Also on the struct wrappers (`ParsedS3Url` and `StoreAndPath`): coming from a TypeScript & tRPC background, I prefer explicit named structs over anonymous tuples. It keeps the internal contract non-breaking if we expand fields later, eliminates tuple-index swapping bugs, and makes the code much cleaner to read. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
