nssalian commented on PR #18121: URL: https://github.com/apache/iceberg/pull/18121#issuecomment-5701657928
Thanks for linking me to that PR @pvary. I missed it but I did take a look at the implementation. The PR stops at the arrow layer (no Spark StructColumnVector/SparkBatch wiring) and uses an all-children-null heuristic for null structs, so it's incomplete for the Spark vectorized path from my vantage point. I'm fixing the test failures in this PR hence it is still in draft as I work through. Let me push up the changes to get it in a clean state and we can review it once that is done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
