xanderbailey commented on PR #3236: URL: https://github.com/apache/iceberg-rust/pull/3236#issuecomment-5695102804
Thanks for the review: > The one I care most about: encrypted_length() now makes file_length mandatory on every read — metadata(), reader(), and read() all fail hard without it, and there's no stat fallback. That means every encrypted file the earlier PRs in this series already wrote (without file_length) becomes permanently unreadable by iceberg-rust, not just by Java. I don't think we can fall back silently — trusting the declared length is the point — but I'd want us to pick explicitly: a warned fallback that keeps old tables readable, or an accepted hard break called out in the changelog. Right now it's silent either way. iceberg-rust hasn't yet shipped a version with encryption supported so this isn't a break and it's consistent with Java. I was surprised to see that Java client hard throws in this case also I have say -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
