moomindani commented on PR #2804: URL: https://github.com/apache/iceberg-rust/pull/2804#issuecomment-5689756274
Rebased onto current `main`; this had fallen 205 commits behind and was conflicting. Mergeable again, and `cargo test -p iceberg-datafusion` passes (93 + 9 + 1), with clippy, `cargo fmt` and `cargo public-api` all clean. I squashed the six commits into one before rebasing, so your review comments will show as outdated — the code they refer to is unchanged apart from the rebase. @xanderbailey thanks again for the review; all three points are addressed and answered above. If the resolutions look right to you, saying so would help this find a committer. @CTTY @kevinjqliu this one has a completed review round. An INSERT that omits a column currently leaves it NULL even when the Iceberg schema declares a write-default; the table provider now surfaces the default so the planner fills it in. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
