moomindani commented on PR #3474: URL: https://github.com/apache/iceberg-python/pull/3474#issuecomment-5689401262
Still waiting for review — three months open, all feedback answered, 21/21 green and mergeable. Three threads are open on my replies rather than on anything unaddressed, and a yes or no on them is all this needs: - `PuffinWriter` kept as a generic format-level writer, with DV serialization on `DeletionVector.to_blob()`. - `overwrite=True` for idempotency, matching the other write-once writers. - the DV key bound matched to Java's `readKey`, so we cannot write a DV that Java refuses to read. @Fokko you merged #3476, the read-side interop test; this is the writer, and the first step of the plan I sketched on #1078. Would you take a look? @sungwy @ebyhr @rambleraptor you all reviewed earlier rounds — confirming or reopening those three threads would move this either way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
