rdblue commented on code in PR #16936:
URL: https://github.com/apache/iceberg/pull/16936#discussion_r4020803660
##########
core/src/main/java/org/apache/iceberg/TrackedFileAdapters.java:
##########
@@ -62,6 +73,33 @@ static ManifestFile asManifestFile(TrackedFile file) {
return new TrackedManifestFile(file);
}
+ /**
+ * Returns a reusable wrapper that presents a {@link DataFile} as a {@link
TrackedFile} row.
+ *
+ * @param writeSchema the TrackedFile writer schema, including partition and
content-stats types
+ */
+ static DataTrackedFile forDataFile(Schema writeSchema) {
+ return new DataTrackedFile(writeSchema);
+ }
+
+ /**
+ * Returns a reusable wrapper that presents an equality {@link DeleteFile}
as a {@link
+ * TrackedFile} row.
+ *
+ * @param writeSchema the TrackedFile writer schema, including partition and
content-stats types
+ */
+ static EqualityDeleteTrackedFile forEqualityDeleteFile(Schema writeSchema) {
+ return new EqualityDeleteTrackedFile(writeSchema);
+ }
+
+ /**
+ * Returns a reusable wrapper that presents a {@link ManifestFile} as a
{@link TrackedFile} leaf
+ * manifest row.
+ */
+ static ManifestTrackedFile forManifestReference() {
Review Comment:
Why "manifest reference" rather than "manifest file"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
