anuragmantri commented on PR #2671: URL: https://github.com/apache/iceberg-rust/pull/2671#issuecomment-5688717997
Hi @toutane, thanks for this work — I've been building on top of it for a follow-up ([sort-order reporting](https://github.com/apache/iceberg-rust/issues/3126)), so I rebased this branch onto current `main` to test it and found two things worth flagging before merge, both caused by `main` moving forward since your last push rather than anything in this PR's own design: 1. `main` picked up #3091 (`FileScanTask` fields went private behind a serde adapter, `build()` now returns `Result<FileScanTask>`). Your round-robin test in `scan_planning.rs` builds a `FileScanTask` with `.build()` and no `.unwrap()`, which no longer compiles. 2. `main` also picked up a DataFusion bump to 55.0, which deprecated `ExecutionPlan::with_new_children` in favor of `replace_children`/`ReplaceChildrenOptions`. `test_iceberg_table_scan_rejects_non_empty_children` calls `.with_new_children()` directly, which now trips `clippy -D warnings`. Both are one-line fixes, but you'll hit them as soon as you rebase onto current `main`. Happy to share the exact diffs if useful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
