Guosmilesmile commented on code in PR #18123:
URL: https://github.com/apache/iceberg/pull/18123#discussion_r4014011632
##########
flink/v2.3/flink/src/main/java/org/apache/iceberg/flink/sink/SinkUtil.java:
##########
@@ -45,7 +45,7 @@
@Internal
public class SinkUtil {
- private static final long INITIAL_CHECKPOINT_ID = -1L;
+ public static final long INITIAL_CHECKPOINT_ID = -1L;
Review Comment:
package ？
##########
flink/v2.3/flink/src/test/java/org/apache/iceberg/flink/sink/TestIcebergCommitter.java:
##########
@@ -238,6 +238,37 @@ public void testCommitTxn() throws Exception {
}
}
+ @TestTemplate
Review Comment:
Could you add one test that goes through the real IcebergSink instead?
getTestHarness() already builds a real sink and CommitterOperatorFactory, so
IcebergSink#createCommitter is exercised and restored is derived from the
harness state rather than from an argument
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
