manuzhang commented on code in PR #853:
URL: https://github.com/apache/iceberg-cpp/pull/853#discussion_r4013197908
##########
.github/workflows/sanitizer_test.yml:
##########
@@ -64,6 +66,10 @@ jobs:
mkdir build && cd build
cmake .. -G Ninja -DCMAKE_BUILD_TYPE=Debug -DICEBERG_ENABLE_ASAN=ON
-DICEBERG_ENABLE_UBSAN=ON \
-DCMAKE_C_COMPILER_LAUNCHER=sccache
-DCMAKE_CXX_COMPILER_LAUNCHER=sccache
+ if [[ -d _deps/vendoredarrow-src ]]; then
Review Comment:
can this check be moved into CMake?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
