laserninja opened a new pull request, #18112: URL: https://github.com/apache/iceberg/pull/18112
Fixes #18111. Truncating `Integer.MAX_VALUE - 1` with width `Integer.MAX_VALUE` currently produces a negative partition key. A scan filtered by `id >= 0` then omits the matching file. Use `Math.floorMod` in the int and narrow-integer helpers to avoid overflowing the intermediate remainder-plus-width addition. This preserves public APIs and existing behavior when the final mathematical result is outside the target type's range. Validation on JDK 17: - Full `:iceberg-api:test` suite and targeted core truncation and table scan regressions passed. The new regressions failed before the fix. - `:iceberg-api:spotlessCheck :iceberg-core:spotlessCheck` passed. - `:iceberg-api:revapi :iceberg-core:revapi` passed. --- **AI Disclosure** - Model: GPT-6 - Platform/Tool: Codex - Human Oversight: unreviewed - Prompt Summary: Reproduce and fix integer truncation overflow, add regression tests, and create an issue and PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
