RussellSpitzer commented on code in PR #17545:
URL: https://github.com/apache/iceberg/pull/17545#discussion_r4010067578
##########
api/src/main/java/org/apache/iceberg/FileWithKeyId.java:
##########
@@ -18,16 +18,15 @@
*/
package org.apache.iceberg;
-import java.nio.ByteBuffer;
-
-/** A bitmap that is serialized inline in a metadata file. */
-public interface ManifestBitmap {
- /** Number of bits set in this bitmap. */
- int cardinality();
+/**
+ * A file that may be encrypted. If it is encrypted, its encrypted key
metadata is tracked in the
+ * table metadata encryption keys and is referenced by a key ID.
+ */
+public interface FileWithKeyId {
Review Comment:
Name here is a bit weird. "With Key Id" has a lot of weight here and is only
really understandable if you know the context is encryption. This also wouldn't
be a file as much as it would be just a path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
