LouisDeconinck opened a new pull request, #18096: URL: https://github.com/apache/iceberg/pull/18096
## Summary Adds test coverage in `TestParquet` for disabling Parquet column statistics via `write.parquet.stats-enabled.column.<COLUMN_NAME>` on multiple columns at once, the scenario reported in #15347. The multi-column disable path already works correctly on `main` (as confirmed in the issue discussion and in the earlier attempts), so this PR adds regression coverage only — no production code changes. A shared `writeAndAssertColumnStatistics` helper writes records with the given table properties and asserts per-column statistics presence in the Parquet footer. All of the tests share one constant schema and express expectations as a column name to statistics-presence map, per the review feedback on #17365: - `testColumnStatisticsDefault` — no per-column properties; all columns write statistics - `testColumnStatisticsEnabled` — existing test, refactored onto the shared schema and helper (one column enabled, one disabled, one unconfigured) - `testMultipleColumnsStatisticsDisabled` — two columns disabled; both omit statistics while the unconfigured third column still writes them (the reported #15347 scenario) - `testAllColumnsStatisticsDisabled` — statistics disabled on every column in the schema Fixes #15347 ## Test plan - [x] `./gradlew :iceberg-parquet:test --tests 'org.apache.iceberg.parquet.TestParquet'` — 26 tests, all pass - [x] `./gradlew :iceberg-parquet:spotlessCheck` — clean --- **AI Disclosure** - Model: [unknown - human to fill in] - Platform/Tool: Devin - Human Oversight: unreviewed - Prompt Summary: Investigate apache/iceberg#15347 and contribute a fix consistent with maintainer feedback on prior attempts -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
