kevinjqliu commented on code in PR #18042:
URL: https://github.com/apache/iceberg/pull/18042#discussion_r3994431980
##########
build.gradle:
##########
@@ -1258,8 +1258,11 @@ project(':iceberg-bom') {
// only contain artifacts for that single Scala version. The following
code ensures that
// the BOM references the artifacts for all Scala versions.
def sparkScalaPattern = ~"(.*)-([0-9][.][0-9]+)_([0-9][.][0-9]+)"
+ // Only include Spark versions published in binary releases.
def sparkScalaVersions = [
"3.5": ["2.12", "2.13"],
+ "4.0": ["2.13"],
+ "4.1": ["2.13"],
Review Comment:
this is a separate BOM issue.
##########
.github/workflows/publish-snapshot.yml:
##########
@@ -53,4 +53,8 @@ jobs:
run: |
./gradlew printVersion
./gradlew -DallModules publishApachePublicationToMavenRepository
-PmavenUser="$NEXUS_USER" -PmavenPassword="$NEXUS_PW"
- ./gradlew -DflinkVersions= -DsparkVersions=3.5,4.0
-DscalaVersion=2.13 -DkafkaVersions=3 publishApachePublicationToMavenRepository
-PmavenUser="$NEXUS_USER" -PmavenPassword="$NEXUS_PW"
+ ./gradlew -DflinkVersions= -DsparkVersions=3.5 -DscalaVersion=2.13
-DkafkaVersions= \
Review Comment:
I see, so the first `./gradlew -DallModules` command publishes all the
packages and uses the default 2.12 scala.
Spark 3.5 is the odd one out, it needs to publish package for both 2.12 and
2.13
https://github.com/apache/iceberg/blob/cff60bc18e6fea1e29990f7f6d5ac78891defa59/build.gradle#L1257-L1263
So this second command publishes explicitly for 2.13
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
