pvary commented on code in PR #17859:
URL: https://github.com/apache/iceberg/pull/17859#discussion_r3986824710
##########
flink/v2.3/flink/src/main/java/org/apache/iceberg/flink/FlinkCatalog.java:
##########
@@ -321,8 +339,30 @@ public void alterDatabase(String name, CatalogDatabase
newDatabase, boolean igno
@Override
public List<String> listTables(String databaseName)
throws DatabaseNotExistException, CatalogException {
+ List<String> results;
try {
- return icebergCatalog.listTables(appendLevel(baseNamespace,
databaseName)).stream()
+ results =
+ icebergCatalog.listTables(appendLevel(baseNamespace,
databaseName)).stream()
+ .map(TableIdentifier::name)
+ .collect(Collectors.toList());
Review Comment:
nit: shall we use `.toList()` since we use new Java?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
