kevinjqliu commented on code in PR #3193: URL: https://github.com/apache/iceberg-rust/pull/3193#discussion_r3980556456
########## .gitattributes: ########## @@ -1,10 +1,20 @@ # Paths left out of the source archive built by dev/release/create_rc.sh. # Files needed to build, test, and verify from source (dev/, .licenserc.yaml, # lint configs) must stay in. +# +# .github is listed entry by entry rather than wholesale: GitHub resolves the +# `uses: $/...` self-repository action references in our workflows by fetching a +# repository archive, which honours export-ignore. Excluding .github as a whole +# therefore hides .github/actions from that fetch and every workflow using a +# local composite action fails with "Can't find 'action.yml'". website export-ignore .asf.yaml export-ignore .devcontainer export-ignore .gitattributes export-ignore -.github export-ignore +.github/ISSUE_TEMPLATE export-ignore +.github/PULL_REQUEST_TEMPLATE.md export-ignore +.github/copilot-instructions.md export-ignore +.github/dependabot.yml export-ignore +.github/workflows export-ignore Review Comment: ```suggestion ``` what do you think about if we just remove `.github export-ignore` entirely? so we dont need to keep this list updated ########## .gitattributes: ########## @@ -1,10 +1,20 @@ # Paths left out of the source archive built by dev/release/create_rc.sh. # Files needed to build, test, and verify from source (dev/, .licenserc.yaml, # lint configs) must stay in. +# +# .github is listed entry by entry rather than wholesale: GitHub resolves the +# `uses: $/...` self-repository action references in our workflows by fetching a +# repository archive, which honours export-ignore. Excluding .github as a whole +# therefore hides .github/actions from that fetch and every workflow using a +# local composite action fails with "Can't find 'action.yml'". Review Comment: ```suggestion # .github must stay in too: `uses: $/...` action references are resolved from # the repository archive, which honors export-ignore. ``` maybe something smaller -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
