pvary commented on code in PR #18037:
URL: https://github.com/apache/iceberg/pull/18037#discussion_r3978015469


##########
mr/src/main/java/org/apache/iceberg/mr/mapreduce/IcebergInputFormat.java:
##########
@@ -313,6 +316,9 @@ private CloseableIterable<T> openTask(FileScanTask 
currentTask, Schema readSchem
           encryptionManager.decrypt(
               EncryptedFiles.encryptedInput(io.newInputFile(file.location()), 
file.keyMetadata()));
 
+      Map<Integer, ?> partition =

Review Comment:
   could we call it `idToConstant`, or just immediately set on the builder in 
line 337?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to