JeonDaehong commented on PR #18027: URL: https://github.com/apache/iceberg/pull/18027#issuecomment-5603751242
Hello @aokolnychyi @huaxingao Tagging you as the people who have worked most on these files. No rush at all, a look whenever you have time would be much appreciated. I tried to make this easy to evaluate rather than something you have to take on trust. The change was measured across delete densities from 0.5% to 50%, on three CPU microarchitectures, and on both local disk and S3. I also used hardware counters to verify the underlying mechanism instead of inferring it from timings, which is actually how I realized my initial explanation for the cost was incorrect. The linked issue also lists the conditions under which these numbers do not hold. I am happy to adjust the approach if you see a better way forward. If this direction looks right, I will backport it to v3.5, v4.0, and v4.1 in a follow-up PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
