singhpk234 commented on code in PR #15895:
URL: https://github.com/apache/iceberg/pull/15895#discussion_r3926805583
##########
api/src/main/java/org/apache/iceberg/catalog/SessionCatalog.java:
##########
@@ -222,6 +222,19 @@ default boolean tableExists(SessionContext context,
TableIdentifier ident) {
*/
Table loadTable(SessionContext context, TableIdentifier ident);
+ /**
+ * Load a table, passing the context it is being loaded with.
+ *
+ * @param context session context
+ * @param ident a table identifier
+ * @param loadContext context for this load
+ * @return instance of {@link Table} implementation referred by {@code ident}
+ * @throws NoSuchTableException if the table does not exist
+ */
+ default Table loadTable(SessionContext context, TableIdentifier ident,
LoadContext loadContext) {
+ throw new UnsupportedOperationException("Loading a table with context is
not supported");
Review Comment:
> This means a catalog is always free to just ignore the context package
Thats fair from catalog POV, but is it still ok that the client contract,
would expect that this api to forward this and a catalog implementation just
ignores passing this context to the catalog (since the default method skips
passing this context) this gets a bit tricky since this a new api in the
existing interface .... i think in the **mixin** case we could have done that
for sure ! sine the existing implementation of the interface is not gonna get
prompted (though we need this for rest catalog only though :)) which we will do
!
please let me know your thoughts considering above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
